stevedlawrence commented on a change in pull request #262: Unordered sequences
URL: https://github.com/apache/incubator-daffodil/pull/262#discussion_r318126517
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/AlignedMixin.scala
##########
@@ -171,17 +192,21 @@ trait AlignedMixin extends GrammarMixin { self: Term =>
}
val priorSibsAlignmentsApprox = priorSibs.map { ps =>
- val eaa = ps.endingAlignmentApprox
+ val eaa = if (nearestEnclosingSequence.isDefined &&
!nearestEnclosingSequence.get.isOrdered) {
Review comment:
This if condition is repeated a lot. Can we add a variable like
``isInUnorderedSequence``?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
