stevedlawrence commented on a change in pull request #262: Unordered sequences
URL: https://github.com/apache/incubator-daffodil/pull/262#discussion_r318613911
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/SequenceGrammarMixin.scala
##########
@@ -135,7 +141,10 @@ trait SequenceGrammarMixin extends GrammarMixin { self:
SequenceTermBase =>
case (e: EB, Ordered__, TrailingStr, Implicit__, ___, UNB) => new
RepOrderedWithMinMaxSequenceChild(this, e, groupIndex)
case (e: EB, Ordered__, TrailingStr, Implicit__, ___, max) => new
RepOrderedWithMinMaxSequenceChild(this, e, groupIndex)
case (e: EB, Ordered__, Always_____, Implicit__, ___, max) => new
RepOrderedWithMinMaxSequenceChild(this, e, groupIndex)
- case (m: MG, Ordered__, ___________, __________, ___, __2) => new
ScalarOrderedSequenceChild(this, m, groupIndex)
+ case (e: EB, Unordered, ___________, Parsed____, ONE, ONE) => new
ScalarOrderedSequenceChild(this, e, groupIndex)
+ case (e: EB, Unordered, ___________, Parsed____, ___, max) => new
RepOrderedWithMinMaxSequenceChild(this, e, groupIndex)
+ case (e: EB, Unordered, ___________, __________, ___, __2) =>
e.SDE("When sequenceKind='unordered', occursCountKind must be 'parsed'")
Review comment:
Makes me wonder if we even need the RepOrdered class and the ONE, ONE match?
Since you could have between min and max elements, just out of order? Maybe
ever element is parsed one at a time in the choice/sequence stuff?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
