jadams-tresys commented on a change in pull request #262: Unordered sequences
URL: https://github.com/apache/incubator-daffodil/pull/262#discussion_r320372216
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceParserBases.scala
##########
@@ -44,6 +50,45 @@ abstract class SequenceParserBase(
override lazy val childProcessors = childParsers
}
+abstract class UnorderedSequenceParserBase(
+ srd: SequenceRuntimeData,
+ choiceParser: ChoiceParser)
+ extends SequenceParserBase(srd, Vector(choiceParser)) {
+
+ override protected def parse(pstate: PState) = {
+
+ var isDone = false
+
+ while (!isDone && (pstate.processorStatus eq Success)) {
Review comment:
While I'm not saying that I am doing things correctly, I do have tests with
separatorPosition=prefix and postfix that all produce the expected results.
That being said, I'm sure I haven't tested every edge case.
I'll start working on making the changes to use OrderedSeparatedParser
instead of the Unordered one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
