jadams-tresys commented on a change in pull request #262: Unordered sequences
URL: https://github.com/apache/incubator-daffodil/pull/262#discussion_r320379207
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceParserBases.scala
##########
@@ -44,6 +50,45 @@ abstract class SequenceParserBase(
override lazy val childProcessors = childParsers
}
+abstract class UnorderedSequenceParserBase(
+ srd: SequenceRuntimeData,
+ choiceParser: ChoiceParser)
+ extends SequenceParserBase(srd, Vector(choiceParser)) {
+
+ override protected def parse(pstate: PState) = {
+
+ var isDone = false
+
+ while (!isDone && (pstate.processorStatus eq Success)) {
Review comment:
Just talked with Steve and I agree that this is wrong and probably wouldn't
work for some negative test cases. I'll add a few of those to verify that the
new code is working correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
