+1 from me. I checked that the checked out code builds and runs all built in tests. I inspected the checked out tree and found nothing surprising in it.
Rather than re-inspect to double-check things other people have checked I decided to re-verify the essential functionality of the release, which is the speedup and reduced memory footprint of the DFDL schema compiler. I wanted to be sure nothing in the more recent commits had caused regression of this. In particular I tested that some of our very largest DFDL schemas, which used to compile in many minutes and required many gigs of RAM to do so on Daffodil 2.5.0, now behave much better in 2.6.0. I am satisfied that nothing has regressed. Schema EDIFACT works with 'sbt -mem 320 test'. That's only 320Meg of RAM. I verified this with visualvm. It takes about 20 seconds to compile the schema. It won't go much lower than that "-mem 256' failed with GC overhead/out-of-memory conditions. Schema stanag-5516-with-nact works with 'sbt -mem 1024 test' Takes about 1 minute to compile and run the slowest test, which is still very slow, but is far less than it was. BTW: this schema I modified to include *every* message. In the past due to the long compilation times we had commented out all but a handful of messages, and it still took many minutes to compile. This schema does seem to need roughly this "-mem 1024' (which is 1 gigabyte) memory level. It failed with 'sbt -mem 768 test'. I did spot an issue not with the release per-se, but with the release page for our site. It's a nit, but there is a hyperlink mid page that should take you to the Deprecation/Compatibility section at the bottom, and that hyperlink does not work. -mike beckerle On 4/9/20 1:05 PM, Olabusayo Kilo wrote: > Hi all, > > I'd like to call a vote to release Apache Daffodil (incubating) 2.6.0-rc2. > > All distribution packages, including signatures, digests, etc. can be > found at: > > https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.6.0-rc2/ > > Staging artifacts can be found at: > > https://repository.apache.org/content/repositories/orgapachedaffodil-1015 > > This release has been signed with PGP key 639637FDA8049411, > corresponding to olabus...@apache.org, which is included in the KEYS > file here: > > https://downloads.apache.org/incubator/daffodil/KEYS > > The release candidate has been tagged in git with v2.6.0-rc2. > > For reference, here is a list of all closed JIRAs tagged with 2.6.0: > > https://s.apache.org/daffodil-issues-2.6.0 > > For a summary of the changes in this release, see: > > https://daffodil.apache.org/releases/2.6.0/ > > Please review and vote. The vote will be open for at least 72 hours > (ends on Sunday, 12 April 2020, 12 Noon EST). > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why)
