The test appears to be non-deterministic because the ORDER BY is only on the first column, so this doesn't seem to be a blocker for releasing the patch.
+1 (binding) Thanks, Andrew! On Thu, Aug 14, 2025 at 8:43 AM Andy Grove <[email protected]> wrote: > I downloaded the tarball, verified the checksum, ran the release > verification script from the downloaded source, and saw the following test > failure: > > External error: 1 errors in file > /tmp/datafusion-49.0.1.RnL9I/apache-datafusion-49.0.1/datafusion/sqllogictest/test_files/joins.slt > > 1. query result mismatch: > [SQL] SELECT t1_id, t1_name, t2_name FROM t1 CROSS JOIN t2 ORDER BY t1_id > [Diff] (-expected|+actual) > - 11 a z > - 11 a y > 11 a x > 11 a w > + 11 a z > + 11 a y > + 22 b x > + 22 b w > 22 b z > 22 b y > - 22 b x > - 22 b w > + 33 c x > + 33 c w > 33 c z > 33 c y > - 33 c x > - 33 c w > - 44 d z > - 44 d y > 44 d x > - 44 d w > + 44 d w > + 44 d z > + 44 d y > at > /tmp/datafusion-49.0.1.RnL9I/apache-datafusion-49.0.1/datafusion/sqllogictest/test_files/joins.slt:727 > > > On Thu, Aug 14, 2025 at 8:28 AM Andrew Lamb <[email protected]> > wrote: > >> Hi, >> >> I would like to propose a release of Apache DataFusion version 49.0.1. >> >> This release candidate is based on commit: >> d1a6e9a6558300115d913a54bbea27e141156606 [1] >> The proposed release tarball and signatures are hosted at [2]. >> The changelog is located at [3]. >> >> Please download, verify checksums and signatures, run the unit tests, and >> vote >> on the release. The vote will be open for at least 72 hours. >> >> Only votes from PMC members are binding, but all members of the community >> are >> encouraged to test the release and vote with "(non-binding)". >> >> The standard verification procedure is documented at >> >> https://github.com/apache/datafusion/blob/main/dev/release/README.md#verifying-release-candidates >> . >> >> [ ] +1 Release this as Apache DataFusion 49.0.1 >> [ ] +0 >> [ ] -1 Do not release this as Apache DataFusion 49.0.1 because... >> >> Here is my vote: >> >> +1 >> >> [1]: >> >> https://github.com/apache/datafusion/tree/d1a6e9a6558300115d913a54bbea27e141156606 >> [2]: >> >> https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-49.0.1-rc1 >> [3]: >> >> https://github.com/apache/datafusion/blob/d1a6e9a6558300115d913a54bbea27e141156606/CHANGELOG.md >> >
