[
https://issues.apache.org/jira/browse/DATASKETCHES-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118229#comment-17118229
]
Jon Malkin commented on DATASKETCHES-5:
---------------------------------------
A patch has been merged into the 2.0.x-incubating branch, and created a PR to
merge the fix into master. The relevant commit is here:
[https://github.com/apache/incubator-datasketches-cpp/pull/148/commits/c12f99ca508e61bccc50d3df229d39ba4fe06b31]
Going to close this, even though the PR is still open, since I'm pretty sure
I'll forget otherwise.
Finally, thank you for catching this!
> Buffer over-read in MurmurHash3_x64_128
> ---------------------------------------
>
> Key: DATASKETCHES-5
> URL: https://issues.apache.org/jira/browse/DATASKETCHES-5
> Project: Apache Datasketches
> Issue Type: Bug
> Reporter: Csaba Ringhofer
> Priority: Critical
>
> MurmurHash3_x64_128 seems to contain a half-commented-out change that leads
> to adding the offset to the key 2 times:
> 'blocks ' is increased:
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L128
> but the following lines assume that 'blocks ' still points to the start of
> the key:
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L115
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L133
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
