[
https://issues.apache.org/jira/browse/DATASKETCHES-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118325#comment-17118325
]
Jon Malkin commented on DATASKETCHES-5:
---------------------------------------
Worth noting that I confirmed the error and validated the fix by generating
random strings of length 1 - 1499 and compared the resulting hashes from both
java and c++. We'll ultimately need to add something along those lines to the
characterization repo and figure out how to trigger it as, say, a
nightly/weekly cron job or something.
> Buffer over-read in MurmurHash3_x64_128
> ---------------------------------------
>
> Key: DATASKETCHES-5
> URL: https://issues.apache.org/jira/browse/DATASKETCHES-5
> Project: Apache Datasketches
> Issue Type: Bug
> Reporter: Csaba Ringhofer
> Assignee: Jon Malkin
> Priority: Critical
>
> MurmurHash3_x64_128 seems to contain a half-commented-out change that leads
> to adding the offset to the key 2 times:
> 'blocks ' is increased:
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L128
> but the following lines assume that 'blocks ' still points to the start of
> the key:
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L115
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L133
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
