mkaszas commented on issue #91: URL: https://github.com/apache/incubator-datasketches-website/issues/91#issuecomment-657702082
Just submitted a PR for `1.`, there's no need to change the way we reference these pages in the navbar or the TOC - the menu items in the toc will be expanded, and the top nav item highlighted when we arrive on one of these pages. For `2.`, as long as we can remove the duplicates from the ToC, this should work as you described. Cross referencing pages and expanding the menu item already works (example: On https://datasketches.apache.org/docs/Architecture/LargeScale.html there is a link to `Spark Examples`) number 3 is a good catch, I didn't think about browser caching. As the toc script is delivered with each page, if some of the pages are cached in your browser, it could happen that for those pages, the ToC script won't work (until the cache is invalidated) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
