leerho commented on issue #91:
URL: 
https://github.com/apache/incubator-datasketches-website/issues/91#issuecomment-657745335


   Hmmm.  Well, as an example, after merging your PR and eliminating the 
duplicates in the ToC and merging that I tried out the new ToC.  And clicking 
on Downloads in the NavBar did not open the ToC. But after dumping the browser 
cache it worked.    
   
   If the website was static for long periods of time, living with the default 
cache invalidation would probably be ok.  But during active development of the 
site it is a PITA.  So I am open to your suggestion.  Is having the separate js 
file and including it on each page a big change?  Also, what downsides would 
there be with this approach?  Is it slower? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to