+1 Checked: - make, make test - python build/install - python kll wrapper - python vector_of_kll wrapper
The only minor problem I see is that the readme in the python directory does not mention the vector_of_kll classes. Otherwise, everything looks good to me. Michael ________________________________ From: Alexander Saydakov <[email protected]> Sent: Sunday, August 16, 2020 7:40 PM To: [email protected] <[email protected]> Subject: Re: [E] [VOTE] Release Apache DataSketches-cpp 2.1.0-incubating-rc1 +1 Checked: - gpg signature - shasum - cmake, make, make test On Fri, Aug 14, 2020 at 5:32 PM Jon Malkin <[email protected]<mailto:[email protected]>> wrote: * ### Minor version: Fix potential crash when querying KLL with complex types, add vector_of_kll to python, add help text to all python methods. ### * ### We will use a 96 hour window for this vote, including the weekend days. ### * Hello Apache DataSketches PPMC and Community, * * * * * Apologies for yet another RC. On the positive side, the library is being used and scrutinized enough to find some bugs that really needed to be fixed. * 1. This is a call for vote to release Apache DataSketches-cpp version: 2.1.0-incubating-rc1 NOTE 1: The C++ code provides a header-only library. Compilation is needed only to build unit tests. A Python extension is also included in this repository as a set of thin wrappers. That does produce a compiled artifact, but is not built by default. NOTE 2: Compiling the C++ unit tests requires CMake 3.12 or newer. 2. Source repository: - https://github.com/apache/incubator-datasketches-cpp<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-datasketches-cpp__%3B!!Op6eflyXZCqGR5I!RFfeCq2HBXLQpn_RI3G_NX44zgpcYGIsO0si1R-SU5npJXcjOvQbOE77z2fMtmIHfrYV%24&data=02%7C01%7Cmhimes%40knights.ucf.edu%7Ca62e2ae5d02746f56e1408d8423dcc83%7C5b16e18278b3412c919668342689eeb7%7C0%7C0%7C637332180475396050&sdata=tbqB4TLlbKZNI%2FUIct3CCQ4tIRCHDWra4%2FAI6pMmMXk%3D&reserved=0> Git Tag for this release: - https://github.com/apache/incubator-datasketches-cpp/tree/2.1.0-incubating-rc1<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-datasketches-cpp%2Ftree%2F2.1.0-incubating-rc1__%3B!!Op6eflyXZCqGR5I!RFfeCq2HBXLQpn_RI3G_NX44zgpcYGIsO0si1R-SU5npJXcjOvQbOE77z2fMtkbNBwi1%24&data=02%7C01%7Cmhimes%40knights.ucf.edu%7Ca62e2ae5d02746f56e1408d8423dcc83%7C5b16e18278b3412c919668342689eeb7%7C0%7C0%7C637332180475396050&sdata=nvZjkkcwRYqjWQYE8Zc%2BWNOggC%2BKdYGWhSazUNTI1%2Fo%3D&reserved=0> on branch 2.1.x-incubating Git HashId for this release starts with: c1a6f8e 3. The Release Candidate / Zip Repository: - https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/2.1.0-incubating-rc1/<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fincubator%2Fdatasketches%2Fcpp%2F2.1.0-incubating-rc1%2F__%3B!!Op6eflyXZCqGR5I!RFfeCq2HBXLQpn_RI3G_NX44zgpcYGIsO0si1R-SU5npJXcjOvQbOE77z2fMthwfMT5I%24&data=02%7C01%7Cmhimes%40knights.ucf.edu%7Ca62e2ae5d02746f56e1408d8423dcc83%7C5b16e18278b3412c919668342689eeb7%7C0%7C0%7C637332180475396050&sdata=Dd4%2BkCiQwt%2BG7BBCnXbhoSjqI%2Fc1xHlxvx3va5gkvew%3D&reserved=0> The public signing key can be found in the KEYS file: - https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fincubator%2Fdatasketches%2FKEYS__%3B!!Op6eflyXZCqGR5I!RFfeCq2HBXLQpn_RI3G_NX44zgpcYGIsO0si1R-SU5npJXcjOvQbOE77z2fMtrlaGjY_%24&data=02%7C01%7Cmhimes%40knights.ucf.edu%7Ca62e2ae5d02746f56e1408d8423dcc83%7C5b16e18278b3412c919668342689eeb7%7C0%7C0%7C637332180475406043&sdata=P8j4fSaZaUdvwFuR1RMV%2BttRQMilVopiaYchp9xXkz8%3D&reserved=0> The artifacts have been signed with --keyid-format SHORT : 38F334CC 4. C++ Test Guide: - https://github.com/apache/incubator-datasketches-cpp/blob/2.1.0-incubating-rc1/README.md<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-datasketches-cpp%2Fblob%2F2.1.0-incubating-rc1%2FREADME.md__%3B!!Op6eflyXZCqGR5I!RFfeCq2HBXLQpn_RI3G_NX44zgpcYGIsO0si1R-SU5npJXcjOvQbOE77z2fMtjZivnFm%24&data=02%7C01%7Cmhimes%40knights.ucf.edu%7Ca62e2ae5d02746f56e1408d8423dcc83%7C5b16e18278b3412c919668342689eeb7%7C0%7C0%7C637332180475406043&sdata=utkS%2Fn4nNdUysmb7RjgZcdljCPQy5F4ooVeyxjjFUjI%3D&reserved=0>Z 5. Python Build & Test Guide: - https://github.com/apache/incubator-datasketches-cpp/blob/2.1.0-incubating-rc1/python/README.md<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-datasketches-cpp%2Fblob%2F2.1.0-incubating-rc1%2Fpython%2FREADME.md__%3B!!Op6eflyXZCqGR5I!RFfeCq2HBXLQpn_RI3G_NX44zgpcYGIsO0si1R-SU5npJXcjOvQbOE77z2fMtuvfVtK3%24&data=02%7C01%7Cmhimes%40knights.ucf.edu%7Ca62e2ae5d02746f56e1408d8423dcc83%7C5b16e18278b3412c919668342689eeb7%7C0%7C0%7C637332180475416042&sdata=qM%2BHaK5tBllWKbCRtSJ22yg%2BhOtUgTzUU%2FZ9TFQi7Ro%3D&reserved=0> 6. The vote will be performed in two stages: - This letter will be published on dev@ and remain open for at least 72 hours and at least 3 (+1) PPMC votes or a majority of (+1) are acquired. All PPMC members including Mentors can vote. However, a negative vote from a Mentor will cancel this voting process. - After it passes the first stage, the summary of that vote and the key information from this letter will be published on general@incubator and remain open for at least 72 hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason Thanks, Jon Malkin [email protected]<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__http%3A%2F%2Fjmalkinapache.org__%3B!!Op6eflyXZCqGR5I!RFfeCq2HBXLQpn_RI3G_NX44zgpcYGIsO0si1R-SU5npJXcjOvQbOE77z2fMth7UoQAj%24&data=02%7C01%7Cmhimes%40knights.ucf.edu%7Ca62e2ae5d02746f56e1408d8423dcc83%7C5b16e18278b3412c919668342689eeb7%7C0%7C0%7C637332180475416042&sdata=ABONlO2pSPGJby4fb4GWAMs7hBzAyRMkaLELC3cQfUc%3D&reserved=0>
