+1 (binding)

Checked incubating in name
Checked signature and checksum
Checked LICENSE
Checked NOTICE
Checked DISCLAIMER-WIP
Ran RAT Check.

https://creadur.apache.org/rat/download_rat.cgi
java -jar ~/Development/apache-rat-0.12.jar . > rat-report

Noticed one missing license:
=====================================================
== File: ./common/test/catch.hpp
=====================================================
/*
 *  Catch v2.11.3
 *  Generated: 2020-03-19 13:44:21.042491
 *  ----------------------------------------------------------
 *  This file has been merged from multiple headers. Please don't edit it 
directly
 *  Copyright (c) 2020 Two Blue Cubes Ltd. All rights reserved.
 *
 *  Distributed under the Boost Software License, Version 1.0. (See accompanying
 *  file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 */

These are missing headers:
=====================================================
== File: ./common/test/catch_runner.cpp
=====================================================

=====================================================
== File: ./hll/include/hll.private.hpp
=====================================================

Fix those in the next release and you can goto a normal DISCLAIMER for this 
product.

Regards,
Dave

> On Aug 14, 2020, at 5:31 PM, Jon Malkin <[email protected]> wrote:
> 
>       • ### Minor version: Fix potential crash when querying KLL with complex 
> types, add vector_of_kll to python, add help text to all python methods. ###
>       • ### We will use a 96 hour window for this vote, including the weekend 
> days. ###
>       • 
> Hello Apache DataSketches PPMC and Community,
> 
> 
> 
> 
>       • Apologies for yet another RC. On the positive side, the library is 
> being used and scrutinized enough to find some bugs that really needed to be 
> fixed.
>       •  1. This is a call for vote
>  to release Apache DataSketches-cpp version: 2.1.0-incubating-rc1
> 
>     NOTE 1: The C++ code provides a header-only library. Compilation is 
> needed only to build unit tests. A Python extension is also included in this 
> repository as a set of thin wrappers. That does produce a compiled artifact, 
> but is not built by default.
> 
>     NOTE 2: Compiling the C++ unit tests requires CMake 3.12 or newer.
> 
> 2. Source repository:
>     - 
> https://github.com/apache/incubator-datasketches-cpp
> 
> 
>     Git Tag for this release:
>     - 
> https://github.com/apache/incubator-datasketches-cpp/tree/2.1.0-incubating-rc1
>  on branch 2.1.x-incubating
> 
>     Git HashId for this release starts with: c1a6f8e
> 
> 3. The Release Candidate / Zip Repository:
>     - 
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/2.1.0-incubating-rc1/
> 
> 
>     The public signing key can be found in the KEYS file:  
>     - 
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
> 
>     
>     The artifacts have been signed with --keyid-format SHORT : 38F334CC
> 
> 4. C++ Test Guide:
>     - 
> https://github.com/apache/incubator-datasketches-cpp/blob/2.1.0-incubating-rc1/README.md
> Z
> 
> 
> 5. Python Build & Test Guide:
>     - 
> https://github.com/apache/incubator-datasketches-cpp/blob/2.1.0-incubating-rc1/python/README.md
> 
> 
> 6. The 
> vote
>  will be performed in two stages:
>    - This letter will be published on dev@ and remain open for at least 72 
> hours and at least 3 (+1) PPMC 
> votes or a majority of (+1) are acquired. All PPMC members including Mentors 
> can vote. However, a negative vote from a Mentor will cancel this voting
>  process. 
>      
>    - After it passes the first stage, the summary of that 
> vote and the key information from this letter will be published on 
> general@incubator and remain open for at least 72 hours and at least 3 (+1) 
> IPMC votes
>  or a majority of (+1) are acquired.
> 
> Please 
> vote
>  accordingly:
> 
> [ ] +1 approve 
> [ ] +0 no opinion 
> [ ] -1 disapprove with the reason
> 
> 
> Thanks,
> Jon Malkin
> 
> [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to