-1 from me as well. Thank you Jon for your review.
In the root pom the apache-rat-plugin excludes need to be corrected: - The <exclude>**/docs/*.md</exclude> , line 325 should be deleted. Documentation files are definitely subject to copyright. I don’t know how that got set. - Add <exclude>**/git.properties</exclude> . This is machine generated, so it doesn’t qualify for license requirements. On Fri, Aug 20, 2021 at 3:52 PM Jon Malkin <[email protected]> wrote: > -1 from me: > > Successful checks: > - shasum, gpg signature > - mvn clean test [-P strict] > - mvn clean package -Denvironment=ci -Dmatrix.jdk.version=? for 8, 9, and > 11 (although the output seems to run all tests each time?) > > Failed action: > - mvn clean install -DskipTests=true > [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check > (default) on project datasketches-memory-root: Too many files with > unapproved license: 1 > > Since the RAT check blocks install it's not ignorable, hence a -1 vote. > > jon > > > On Thu, Aug 19, 2021 at 4:43 PM David Cromberge <[email protected]> > wrote: > >> ### Add support for Java 9 through 13 (inclusive), whilst retaining >> support for Java 8. >> ### Add modularity support via Java Platform Module System for Java9+. >> ### Add support for user to provide memory request server implementation >> for different resource types. >> ### Significant refactoring to better encapsulate internals and simplify >> public facing API. >> ### Add documentation to explain project structure and configuration for >> popular IDEs including Eclipse and IntelliJ. >> >> Hello Apache DataSketches PMC and Community, >> >> 1. This is a call for vote to release Apache DataSketches-memory >> candidate version: 2.0.0-RC1 >> >> NOTE 1: This component of the DataSketches library provides >> high-performance access to off-heap memory for Java applications. These are >> low-level functions that are used by other DataSketches components. It does >> not provide any command-line interface or GUI. >> >> 2. Source repository: >> - https://github.com/apache/datasketches-memory >> >> Git Tag for this release: >> - https://github.com/apache/datasketches-memory/tree/2.0.0-RC1 on >> branch 2.0.X >> >> Git HashId for this release starts with: 86de062 >> >> 3. The Release Candidate / Zip Repository: >> - >> https://dist.apache.org/repos/dist/dev/datasketches/memory/2.0.0-RC1/ >> >> The public signing key can be found in the KEYS file: >> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >> >> The artifacts have been signed with --keyid-format SHORT : A21C4E36 >> >> 4. Repository: Maven Central [Nexus](http://repository.apache.org) (Jar >> Artifacts): >> - >> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-memory/2.0.0/ >> >> 5. Build & Test Guide: >> - >> https://github.com/apache/datasketches-memory/blob/2.0.0-RC1/README.md >> >> 6. The vote will be performed as follows: >> - This letter will be published on dev@ and remain open for at least >> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >> votes or a majority of (+1) PMC votes are acquired. Anyone in the community >> can vote. >> >> Please vote accordingly: >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove with the reason >> >> Thanks, >> David Cromberge >> [email protected] >> >
