Hi,
+1 from me.
Checked:
LICENSE
README.md
NOTICE
Signature integrity using gpg key 41A98F6038F334CC
C++ Build:
cmake (no errors)
make test (pass)
Python:
Build successfully using install and setup.py.
Tested package import from python shell.
I could not figure out how to run the python tests with tox.
David
> On 24 Sep 2021, at 10:02, Jon Malkin <[email protected]> wrote:
>
> Hello Apache DataSketches PMC and Community,
>
> This is a call for vote to release Apache DataSketches-cpp candidate version:
> 3.2.0-RC1
>
> Changes since the last release (3.1.0):
> - Refactor Python to make pybind11 a dependency rather than a submodule
> - Create Python Wheels suitable for upload to PyPI
> - Fix issue #236 (kll_sketch serialization bug)
>
> Changes since rc1:
> - Removed unneeded pybind11 as install dependency
> - Added pybind11 into LICENSE (only relevant for convenience binaries
> from pypi)
> - Improved pypi short and long descriptions
> - Updated python package author to ASF
>
>
> Note that as of this vote the artifacts are not yet in PyPI.
>
> Source repository:
> - https://github.com/apache/datasketches-cpp
> <https://www.google.com/url?q=https://github.com/apache/datasketches-cpp&source=gmail-imap&ust=1633078949000000&usg=AOvVaw1NB4wMPAyN3m5OCUiD3jg3>
>
> Git Tag for this release:
> - https://github.com/apache/datasketches-cpp/tree/3.2.0-rc2
> <https://www.google.com/url?q=https://github.com/apache/datasketches-cpp/tree/3.2.0-rc2&source=gmail-imap&ust=1633078949000000&usg=AOvVaw3xHIqrWdgPrJBU1dYUbdzQ>
> on branch 3.2.x
>
> Git HashId for this release starts with: a1f5c54
>
> The Release Candidate / Zip Repository:
> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.2.0-rc2/
> <https://www.google.com/url?q=https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.2.0-rc2/&source=gmail-imap&ust=1633078949000000&usg=AOvVaw0bW3k31XQASJvueYfwOZ7W>
>
> The public signing key can be found in the KEYS file:
> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> <https://www.google.com/url?q=https://dist.apache.org/repos/dist/dev/datasketches/KEYS&source=gmail-imap&ust=1633078949000000&usg=AOvVaw1r8xOwtSZRUCqAB1qDPRDV>
>
> The artifacts have been signed with key:
> 41A98F6038F334CC 2020-04-30 Jon Malkin (Apache code signing)
> <[email protected] <mailto:[email protected]>>
>
> Build & Test Guide:
> - https://github.com/apache/datasketches-cpp/blob/3.2.0-rc2/README.md
> <https://www.google.com/url?q=https://github.com/apache/datasketches-cpp/blob/3.2.0-rc2/README.md&source=gmail-imap&ust=1633078949000000&usg=AOvVaw36U2hcvY_zR-_zGUmDwEnI>
>
> Python Extension Build & Test Guide:
> -
> https://github.com/apache/datasketches-cpp/blob/3.2.0-rc2/python/README.md
> <https://www.google.com/url?q=https://github.com/apache/datasketches-cpp/blob/3.2.0-rc2/python/README.md&source=gmail-imap&ust=1633078949000000&usg=AOvVaw2-M5336-ZR2s-OmL8P0KKR>
>
> The vote will be performed as follows:
> - This letter will be published on dev@ and remain open for at least 72
> hours (excluding weekends and holidays), AND until at least 3 (+1) PMC votes
> or a majority of (+1) PMC votes are acquired. Anyone in the community can
> vote.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> Jon Malkin
> [email protected] <mailto:[email protected]>
