+1 - verified GPG signature - checked shasum - built C++ code: cmake, make, make test - run Python tests: tox - installed package: python3 -m pip install datasketches - manually run a few commands in Python: import, instantiate a sketch, update a few times, print sketch summary
On Fri, Sep 24, 2021 at 7:11 AM David Cromberge < [email protected]> wrote: > Hi, > > +1 from me. > > Checked: > > LICENSE > README.md > NOTICE > Signature integrity using gpg key 41A98F6038F334CC > > C++ Build: > > cmake (no errors) > make test (pass) > > Python: > > Build successfully using install and setup.py. > Tested package import from python shell. > I could not figure out how to run the python tests with tox. > > David > > > On 24 Sep 2021, at 10:02, Jon Malkin <[email protected]> wrote: > > Hello Apache DataSketches PMC and Community, > > This is a call for vote to release Apache DataSketches-cpp candidate > version: 3.2.0-RC1 > > Changes since the last release (3.1.0): > - Refactor Python to make pybind11 a dependency rather than a submodule > - Create Python Wheels suitable for upload to PyPI > - Fix issue #236 (kll_sketch serialization bug) > > Changes since rc1: > - Removed unneeded pybind11 as install dependency > - Added pybind11 into LICENSE (only relevant for convenience binaries > from pypi) > - Improved pypi short and long descriptions > - Updated python package author to ASF > > > Note that as of this vote the artifacts are not yet in PyPI. > > Source repository: > - https://github.com/apache/datasketches-cpp > <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__github.com_apache_datasketches-2Dcpp-26source-3Dgmail-2Dimap-26ust-3D1633078949000000-26usg-3DAOvVaw1NB4wMPAyN3m5OCUiD3jg3&d=DwMFAg&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=hTFYwmaJmQFxRMrEA2WNy4I3Pa4JOWZqfodqhfQF-1k&s=qV7kALRlKXSWaVDQYo-8nRszkDLcvI0b7c4GEDO9xj0&e=> > > Git Tag for this release: > - https://github.com/apache/datasketches-cpp/tree/3.2.0-rc2 > <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__github.com_apache_datasketches-2Dcpp_tree_3.2.0-2Drc2-26source-3Dgmail-2Dimap-26ust-3D1633078949000000-26usg-3DAOvVaw3xHIqrWdgPrJBU1dYUbdzQ&d=DwMFAg&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=hTFYwmaJmQFxRMrEA2WNy4I3Pa4JOWZqfodqhfQF-1k&s=9fkJEoy9csPE5aHRtdkmgNDWDnSniMNG7jDmkXILQjQ&e=> > on > branch 3.2.x > > Git HashId for this release starts with: a1f5c54 > > The Release Candidate / Zip Repository: > - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.2.0-rc2/ > <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__dist.apache.org_repos_dist_dev_datasketches_cpp_3.2.0-2Drc2_-26source-3Dgmail-2Dimap-26ust-3D1633078949000000-26usg-3DAOvVaw0bW3k31XQASJvueYfwOZ7W&d=DwMFAg&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=hTFYwmaJmQFxRMrEA2WNy4I3Pa4JOWZqfodqhfQF-1k&s=yLiD9GHEmZonM3mY_4VBrXK_a8npIn0wBftRtv217Yg&e=> > > The public signing key can be found in the KEYS file: > - https://dist.apache.org/repos/dist/dev/datasketches/KEYS > <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__dist.apache.org_repos_dist_dev_datasketches_KEYS-26source-3Dgmail-2Dimap-26ust-3D1633078949000000-26usg-3DAOvVaw1r8xOwtSZRUCqAB1qDPRDV&d=DwMFAg&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=hTFYwmaJmQFxRMrEA2WNy4I3Pa4JOWZqfodqhfQF-1k&s=6j0IGvDO_nYclDSRBWWIvmNStEv7dK9YG-Iu6e9pXIk&e=> > > > The artifacts have been signed with key: > 41A98F6038F334CC 2020-04-30 Jon Malkin (Apache code signing) < > [email protected]> > > Build & Test Guide: > - https://github.com/apache/datasketches-cpp/blob/3.2.0-rc2/README.md > <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__github.com_apache_datasketches-2Dcpp_blob_3.2.0-2Drc2_README.md-26source-3Dgmail-2Dimap-26ust-3D1633078949000000-26usg-3DAOvVaw36U2hcvY-5FzR-2D-5FzGUmDwEnI&d=DwMFAg&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=hTFYwmaJmQFxRMrEA2WNy4I3Pa4JOWZqfodqhfQF-1k&s=aZDSinDh-1BO8PxCnavcC9BaWAJvmHKS1AQ4DEriPts&e=> > > Python Extension Build & Test Guide: > - > https://github.com/apache/datasketches-cpp/blob/3.2.0-rc2/python/README.md > <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__github.com_apache_datasketches-2Dcpp_blob_3.2.0-2Drc2_python_README.md-26source-3Dgmail-2Dimap-26ust-3D1633078949000000-26usg-3DAOvVaw2-2DM5336-2DZR2s-2DOmL8P0KKR&d=DwMFAg&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=hTFYwmaJmQFxRMrEA2WNy4I3Pa4JOWZqfodqhfQF-1k&s=UHykiQ61DgwGeiwv1jm9qiPDGJwjbAFd_J26bcFTkPU&e=> > > > The vote will be performed as follows: > - This letter will be published on dev@ and remain open for at least > 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC > votes or a majority of (+1) PMC votes are acquired. Anyone in the > community can vote. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thank you, > Jon Malkin > [email protected] > > >
