+1 (binding) My checks: * Verify shasum and signature for all files, including pypi directory * cmake -B build -S . -DCMAKE_BUILD_TYPE=Release -DWITH_PYTHON=1 (after creating a venv and installing pybind11-global) * cmake --build build -t all test * tox * Installed the relevant pypi file for my desktop and ran all the python tests directly * Verified that all new files have appropriate license header
jon On Wed, Apr 26, 2023 at 11:38 AM Alexander Saydakov <[email protected]> wrote: > Hello Apache DataSketches PMC and Community, > > > This is a call for vote to release Apache DataSketches-cpp candidate > version 4.1.0-rc1 > > > Changes since datasketches-cpp 4.0.0 release (5 Dec 2022): > > - HLL union speed improvement > > - Fixed a bug in theta and tuple union base > > - new density sketch > > - new count min sketch > > - thread local random generator > > - generic quantile sketches in Python (KLL, REQ, classic quantiles) > > - generic frequent items sketch in Python > > - generic tuple sketch in Python > > - added optional compression of serialized theta sketch > > - iterators use new style (no inheritance from std::iterator) > > > Source repository: > > - https://github.com/apache/datasketches-cpp > > > Git Tag for this release: > > - https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1 on > branch 4.1.x > > > Git HashId for this release is: c3abaaefe5fa400eed99e082af07c1b61a7144db > > > The Release Candidate / Zip Repository, including convenience binaries (in > pypi subdirectory): > > - https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/ > > > The public signing key can be found in the KEYS file: > > - https://dist.apache.org/repos/dist/dev/datasketches/KEYS > <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> > > > > The artifacts have been signed with key: > > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < > [email protected]> > > > Build & Test Guide (C++): > > - https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md > > > Build & Test Guide (Python): > > - > https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md > > > The vote will be performed as follows: > > - This letter will be published on dev@ and remain open for at least > 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC > votes or a majority of (+1) PMC votes are acquired. Anyone in the > community can vote. > > > Please vote accordingly: > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > Thank you, > > Alexander Saydakov > > [email protected] > >
