+1 My checks (on windows 10 w/ VS 2019):
- Verify shasum and signature for source release - build ( cmake -S . -B build\Release && cmake --build build\Release ) - run unit tests ( cmake --build build\Release --target RUN_TESTS ) - build python (python 3.8, python -m pip install . ) - python unit tests ( tox ) Two minor issues I noticed: 1. I think the copyright year needs to be updated in NOTICE 2. the source archive doesn't extract on Windows using the default OS tools (explorer). It results in an empty directory. Using other tools, like 7zip, to extract the archive works fine. Will Will Lauer Senior Principal Architect, Audience & Advertising Reporting Data Platforms & Systems Engineering M 508 561 6427 Champaign Office 1908 S. First St Champaign, IL 61822 On Wed, Apr 26, 2023 at 1:38 PM Alexander Saydakov <[email protected]> wrote: > Hello Apache DataSketches PMC and Community, > > > This is a call for vote to release Apache DataSketches-cpp candidate > version 4.1.0-rc1 > > > Changes since datasketches-cpp 4.0.0 release (5 Dec 2022): > > - HLL union speed improvement > > - Fixed a bug in theta and tuple union base > > - new density sketch > > - new count min sketch > > - thread local random generator > > - generic quantile sketches in Python (KLL, REQ, classic quantiles) > > - generic frequent items sketch in Python > > - generic tuple sketch in Python > > - added optional compression of serialized theta sketch > > - iterators use new style (no inheritance from std::iterator) > > > Source repository: > > - https://github.com/apache/datasketches-cpp > <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_xhqq55x$> > > > Git Tag for this release: > > - https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1 > <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_wTqTGHz$> > on > branch 4.1.x > > > Git HashId for this release is: c3abaaefe5fa400eed99e082af07c1b61a7144db > > > The Release Candidate / Zip Repository, including convenience binaries (in > pypi subdirectory): > > - https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/ > <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_4NPcU12$> > > > The public signing key can be found in the KEYS file: > > - https://dist.apache.org/repos/dist/dev/datasketches/KEYS > <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> > > > > The artifacts have been signed with key: > > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < > [email protected]> > > > Build & Test Guide (C++): > > - https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md > <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_7jP2PtX$> > > > Build & Test Guide (Python): > > - > https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md > <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_3B4Ll-h$> > > > The vote will be performed as follows: > > - This letter will be published on dev@ and remain open for at least > 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC > votes or a majority of (+1) PMC votes are acquired. Anyone in the > community can vote. > > > Please vote accordingly: > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > Thank you, > > Alexander Saydakov > > [email protected] > >
