leerho commented on code in PR #683:
URL: https://github.com/apache/datasketches-java/pull/683#discussion_r2270560413
##########
src/main/java/org/apache/datasketches/quantiles/HeapUpdateDoublesSketch.java:
##########
@@ -373,6 +375,11 @@ MemorySegment getMemorySegment() {
return null;
}
Review Comment:
This Copilot message conflated two different methods together. It points to
the "return null" of getMemorySegment(), then talks about the setReadOnly().
Nonetheless I added javadoc to setReadOnly(). The javadoc of getMemorySegment
in the parent class is already sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For additional commands, e-mail: dev-h...@datasketches.apache.org
