leerho commented on code in PR #683:
URL: https://github.com/apache/datasketches-java/pull/683#discussion_r2274752129


##########
src/main/java/org/apache/datasketches/quantiles/DoublesSketch.java:
##########
@@ -563,6 +564,11 @@ UpdateDoublesSketch downSampleInternal(final DoublesSketch 
srcSketch, final int
    */
   abstract MemorySegment getMemorySegment();
 
+  /**
+   * Sets the internal MemorySegment to Read Only.

Review Comment:
   Reexamining this code I realized that the setReadOnly was not only 
confusing, it was unnecessary.  So it has been removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For additional commands, e-mail: dev-h...@datasketches.apache.org

Reply via email to