freakyzoidberg commented on code in PR #26:
URL: https://github.com/apache/datasketches-rust/pull/26#discussion_r2627334285
##########
src/hll/sketch.rs:
##########
@@ -58,8 +58,9 @@ impl HllSketch {
/// If lg_config_k is not in range [4, 21]
pub fn new(lg_config_k: u8, hll_type: HllType) -> Self {
assert!(
Review Comment:
Definitely for another review but we should be careful to not crash/abort
the program because of bad input from the library.
That should be up to the caller to decide what to do.
And the user should not have to be forced to disabled abort on assert
because of the lib.
We (almost) never use panic/abort/assert call in the various implementation
and relies on exception/errors instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
