notfilippo commented on code in PR #26:
URL: https://github.com/apache/datasketches-rust/pull/26#discussion_r2627347374
##########
src/hll/sketch.rs:
##########
@@ -58,8 +58,9 @@ impl HllSketch {
/// If lg_config_k is not in range [4, 21]
pub fn new(lg_config_k: u8, hll_type: HllType) -> Self {
assert!(
Review Comment:
Yes, although the panic clearly documented in the constructor. I think the
tests are ok as is but we should consider returning a `Result` for invalid
parameters in a separate PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
