Fengzdadi commented on PR #94: URL: https://github.com/apache/datasketches-go/pull/94#issuecomment-3717319726
Hi @proost, I've added compatibility tests, but have a few questions: 1. Test data approach I created test data based on Java's `PreambleUtil.java` format specification (manually constructed hex strings rather than actual Java-generated binary files). For example: ```go // Empty sketch: k=10 hexData := "01020d000a000000" // preamble_longs=1, serVer=2, familyID=13, k=10 ``` Is this approach acceptable, or would you prefer tests using actual binary files generated by Java? --- 2. C++ compatibility I noticed that C++ does not have ReservoirItemsSketch implemented yet. Found this TODO in `var_opt_union_impl.hpp`: ```cpp // TODO: extend to handle reservoir sampling ``` Should I proceed with Java-only compatibility tests for now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
