Fengzdadi commented on PR #94: URL: https://github.com/apache/datasketches-go/pull/94#issuecomment-3721566565
Hi @proost, I've added Go-generated reservoir test data files and updated the tests. ## Current Status ### Go side (this PR) - ✅ Generated `reservoir_long_*.sk` files in `serialization_test_data/go_generated_files/` - ✅ Added serialization tests that read these files ### Java side I noticed that **Java doesn't have `ReservoirCrossLanguageTest.java` yet**. Looking at the Java repository, cross-language tests exist for: - VarOpt ✅ - KLL ✅ - HLL ✅ - CPC ✅ - **Reservoir ❌ (missing)** ## Proposal 1. **Merge this PR** with Go-generated test data 2. **I can submit a PR to datasketches-java** to add `ReservoirCrossLanguageTest.java` 3. **After Java generates reservoir files**, I'll update Go to add Java→Go compatibility tests Does this approach work for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
