leerho commented on code in PR #711:
URL: https://github.com/apache/datasketches-java/pull/711#discussion_r2669590171


##########
pom.xml:
##########
@@ -274,8 +288,6 @@ under the License.
           <useManifestOnlyJar>false</useManifestOnlyJar>
           <redirectTestOutputToFile>true</redirectTestOutputToFile>
           
<reportsDirectory>${project.build.directory}/test-output/${maven.build.timestamp}</reportsDirectory>
-          
<excludedGroups>${testng.generate-java-files},${testng.check-cpp-files},${testng.check-go-files},
-${testng.check-cpp-historical-files}</excludedGroups> <!-- do not indent -->

Review Comment:
   I had set this up so that an ordinary "mvn test" would not generate the java 
files and run the tests against the other languages.  These are run with 
specific profiles.   
   
   Now that we are adding more languages into the mix, I am not clear on what 
you have in mind.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to