leerho commented on code in PR #711:
URL: https://github.com/apache/datasketches-java/pull/711#discussion_r2669609030
##########
pom.xml:
##########
@@ -129,6 +129,20 @@ under the License.
</dependencies>
<build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <!-- Apache Parent pom, pluginManagement-->
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- by default, exclude all snapshot targets -->
+ <!-- this will be overridden on dedicated profile -->
+
<excludedGroups>${testng.generate-java-files},${testng.check-cpp-files},${testng.check-go-files},${testng.check-cpp-historical-files}</excludedGroups>
+ </configuration>
+ </plugin>
+ </plugins>
+ </pluginManagement>
Review Comment:
The ds-java POM does not have any maven modules so there is no inheritance.
I also was warned that a configuration specification in a plugin under
pluginManagement may be ignored by some plugins. Also this configuration will
be overridden by the surefire plugin specified under <build><plugins>. So what
is achieved by putting this plugin under pluginManagement with a different
configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
