proost opened a new issue, #728: URL: https://github.com/apache/datasketches-java/issues/728
[In java](https://github.com/apache/datasketches-java/blob/53b312ec2d32f32261fbaf803a8287f5ebb4ff45/src/main/java/org/apache/datasketches/req/BaseReqSketch.java#L73): Using rank upper bound: ``` public static double getRSE(final int k, final double rank, final boolean hra, final long totalN) { return getRankUB(k, 2, rank, 1, hra, totalN); //more conservative to assume > 1 level } ``` [In C++](https://github.com/apache/datasketches-cpp/blob/f5462628f24e91ef882431ee9344eaa9f97ce5fa/req/include/req_sketch_impl.hpp#L295): Using rank lower bound: ``` template<typename T, typename C, typename A> double req_sketch<T, C, A>::get_RSE(uint16_t k, double rank, bool hra, uint64_t n) { return get_rank_lb(k, 2, rank, 1, n, hra); } ```` which one is correct? Further question: According paper and comments above on the method, I think it should return `min(numStdDev * relative, numStdDev * fixed)`, not the upper bound rank. Did i missread? or historically miss named function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
