leerho commented on issue #728: URL: https://github.com/apache/datasketches-java/issues/728#issuecomment-4086082132
I think you are right. It should be UB_Rank - true_rank It turns out that the getRSE() is not used in Java runtime or in java Characterization. There are two Java tests but they are rather meaningless -- they test that the result is > zero! I think this is why this was never caught before. Alas, "If it isn't tested, it doesn't work!" As one final confirmation, I'm going to bring up the characterization tests and add getRSE() to the tests. This will confirm it statistically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
