hawkingrei commented on PR #142: URL: https://github.com/apache/datasketches-rust/pull/142#issuecomment-4886464099
Addressed the API feedback from @tisonkun: - Removed the `ThetaJaccardSimilarity` unit struct. - Moved the public constructors to `JaccardSimilarity::between(...)` and `JaccardSimilarity::between_with_seed(...)`. - Made `JaccardSimilarity` fields private and exposed immutable getters: `lower_bound()`, `estimate()`, and `upper_bound()`. The tests have been updated to use the new API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
