tisonkun commented on PR #142: URL: https://github.com/apache/datasketches-rust/pull/142#issuecomment-4893672133
@ZENOTME I have two questions: 1. Java's `ThetaSketch::getRetainedEntries` has a `valid` param, but our `CompactThetaSketch::num_retained` doesn't. Could you describe a bit what the design difference between the Java impl and the Rust impl? 2. This PR has a fake `ThetaUnion` impl. Did we have an equivalent ThetaUnion impl so far? I found it strange to have a `pub(super) struct ThetaUnion;`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
