ZENOTME commented on PR #146: URL: https://github.com/apache/datasketches-rust/pull/146#issuecomment-4934132695
> I remember we reject a general `Hashable` solution as in #118. > > But this PR anyway seems like to introduce `RawHashTableEntry` rather than `Hashable`. > > I noticed that it's a crate-level trait. Would it benefits from being an `enum` rather than a `trait`? enum means that entry can be different type in single hash table. But in our case, hash table is reuse as ``` type ThetaHashTable = RawHashTable<ThateHashEntry> type TupleHashTable = RawHashTable<TupleHashEntry> ``` Seems trait is more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
