tisonkun commented on code in PR #146: URL: https://github.com/apache/datasketches-rust/pull/146#discussion_r3558685457
########## datasketches/src/theta/hash_table.rs: ########## @@ -16,20 +16,14 @@ // under the License. use std::hash::Hash; +use std::num::NonZeroU64; -use crate::common::ResizeFactor; -use crate::hash::MurmurHash3X64128; -use crate::hash::compute_seed_hash; -use crate::theta::HASH_TABLE_REBUILD_THRESHOLD; -use crate::theta::HASH_TABLE_RESIZE_THRESHOLD; -use crate::theta::MAX_THETA; -use crate::theta::MIN_LG_K; - -/// Stride hash bits (7 bits for stride calculation) -const STRIDE_HASH_BITS: u8 = 7; - -/// Stride mask -const STRIDE_MASK: u64 = (1 << STRIDE_HASH_BITS) - 1; +use super::raw_hash_table::RawHashTable; +use super::raw_hash_table::RawHashTableEntry; +#[cfg(test)] +pub(crate) use super::raw_hash_table::starting_sub_multiple; +#[cfg(test)] +pub(crate) use super::raw_hash_table::starting_theta_from_sampling_probability; Review Comment: nit: may prefer to `use crate:xxx` since it's more refactor-friendly. But fair enough to gradually converge as we don't have a linter rule to guard it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
