hawkingrei commented on PR #142: URL: https://github.com/apache/datasketches-rust/pull/142#issuecomment-5156260024
Implemented the requested Jaccard design changes in `aeec2fd`: - added `TupleJaccardSimilarity`, including different summary-type coverage; - renamed the shared raw result to `JaccardSimilarity` and kept its fields private; - replaced `between_with_seed` with configured Theta/Tuple operators; - made the shared implementation key-only so Tuple summaries are not cloned or compared; - fixed the zero-retained exact-equality edge case and added Theta/Tuple regressions; - removed the redundant test feature gate; - fixed the existing `htmp` typo and added cross-language bound reference vectors. Local validation passed: - `cargo x prepare-testdata` - `cargo x check` - `cargo x test` - `cargo x lint` The two remaining inline review threads have been answered and resolved. Please take another look when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
