hawkingrei commented on PR #142: URL: https://github.com/apache/datasketches-rust/pull/142#issuecomment-5156367678
Thank you @tisonkun, @ariesdevil, and @ZENOTME for the careful review and design guidance. I incorporated the feedback in `aeec2fd`: - added the Tuple Jaccard implementation to validate the shared extraction; - renamed the shared result to `JaccardSimilarity` and kept its fields private; - followed the configured-operator shape used by A-not-B for seed handling; - made the common path key-only, so Tuple summary values and types do not affect similarity; - fixed the logically non-empty, zero-retained edge case and added Theta/Tuple regressions; - reused the shared union/intersection states and kept `exactly_equal` outside this PR as previously suggested. The repository-required local workflows (`cargo x check`, `cargo x test`, and `cargo x lint`) pass, and the GitHub CI jobs are now running. All existing inline threads have been addressed and resolved. Could you please take another look when convenient? Thanks again for helping improve the API and abstraction boundary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
