pmcgleenon commented on PR #204: URL: https://github.com/apache/datasketches-rust/pull/204#issuecomment-5400788908
I can create a couple of stacked PRs for these two? > [CODEX COMMENT STARTS] I found two correctness issues that I believe need to be fixed before this can be merged. > > 1. **`Compactor::merge` breaks the ordering invariant required by the wire format** I had been looking at introducing ordering in merge in a different context and have something working there. This looks like a good catch > > 2. **Deserialization accepts impossible compactor states that later panic or violate public API contracts** Seems reasonable, I'll take a look at this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
