tisonkun commented on PR #204: URL: https://github.com/apache/datasketches-rust/pull/204#issuecomment-5402878626
> * [benchmarks](https://github.com/pmcgleenon/reqsketch-rs/blob/main/benches/core_benchmarks.rs), I left these out since I didn't see any other benchmarks. Maybe we can add some in a later PR for all the sketches Now we have one under `datasketches/benches`. If the bench-only dependencies get complicated, we can have a standalone local crate like [apache/asyncband's benchmarks](https://github.com/apache/asyncband/tree/879dc4eec566bc2f210d1a8b924fa78ce0f53189/benchmarks). But we can introduce the benchmarks in a follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
