Hi,

+1 (binding).

I verified the source release on macOS 26.6.2 ARM64 with Apple Clang
21 and CMake 4.4.3:
- SHA-512 checksum and PGP signature passed.
- Source files match the release tag, with the additional generated
git.properties recording the correct commit.
- The Release build and all 17 CTest suites passed.
- Installation and an independent C++11 consumer test passed.

I noticed three metadata and documentation issues: the LICENSE entry
for the separately downloaded Catch2 dependency, the NOTICE copyright
year, and the documented minimum CMake version.

I consider these non-blocking for this release and have opened [1] to
address them for the next release.

[1] https://github.com/apache/datasketches-cpp/pull/541

Best,
tison.

Lee Rhodes <[email protected]> 于2026年10月4日周日 09:17写道:
>
> Hello Apache DataSketches PMC and Community,
>
> This is a call for a vote to release Apache DataSketches-cpp candidate 
> version 5.3.0-rc1
>
> Changes from the previous release (5.2.0, January 2025):
>
>     New features:
>     - Theta sketch: optional trim flag on update_theta_sketch::compact();
>       lg_k = 4 is now accepted, matching Java
>     - Count-Min sketch: serialize_to() for caller-supplied sinks;
>       get_hashes() no longer allocates
>     - Frequent items sketch: reset()
>     - t-digest: const iterator over the centroids
>
>     Bug fixes and Java compatibility:
>     - Stricter validation of serialized sketches: malformed or truncated
>       input is rejected with an exception (Bloom filter, CPC, Count-Min,
>       HLL, KLL, Quantiles, REQ, Theta, Tuple, VarOpt)
>     - HLL: fixes to the deferred KxQ rebuild and union estimate;
>       serialization flags aligned with Java
>     - Theta/Tuple: single-item flag, empty-sketch seed hash and A-not-B
>       handling aligned with Java
>     - Frequent items: is_empty() correct after purges
>     - t-digest: rank and quantile tails, merge min/max, iterator and
>       infinite-value fixes
>     - REQ: get_RSE() fixed; VarOpt: only positive weights accepted
>     - GCC 15 build fix, missing standard includes
>
>     Behavior changes will be listed in the release notes on GitHub after the 
> release.
>
> Source repository:
>
>     - https://github.com/apache/datasketches-cpp
>
> Git Tag for this release:
>
>     - https://github.com/apache/datasketches-cpp/releases/tag/5.3.0-rc1 on 
> branch 5.3.x
>
> Git HashId for this release is: 5b5524f55d121225a7909c2851271327684585d7
>
> The Release Candidate Zip Repository:
>
>     - https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.3.0-rc1/
>
> The public signing key can be found in the KEYS file:
>
>     - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>
> The artifacts have been signed with key: --keyid-format SHORT : 8CD4A902
>
> Build & Test Guide:
>
>     - https://github.com/apache/datasketches-cpp/blob/5.3.0-rc1/README.md
>
>     Note: the source zip no longer contains an empty build/ directory, so
>     for the Windows instructions run "mkdir build" first.
>
> The vote will be performed as follows:
>
>    - This letter will be published on dev@ and remain open for at least 72
> hours (excluding weekends and holidays), AND until at least 3 (+1) PMC votes 
> or
> a majority of (+1) PMC votes are acquired.
>    - Anyone in the community can vote.
>    - This vote will close no earlier than Wednesday, Oct 7th 6PM PDT (Oct 8th 
> 01:00 UTC)
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
>
> Lee Rhodes
> [email protected]

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to