leerho opened a new pull request, #14: URL: https://github.com/apache/datasketches-tck/pull/14
Closes #11. **Stacked on #13.** Review that one first. This PR's base will switch to `main` once #13 merges. Moves the snapshots from `serialization/<lang>/snapshots/` to `serialization_test_data/<lang>_generated_files/`. That's the layout datasketches-java and datasketches-go already use for cross-language fixtures, and datasketches-cpp is moving to it (apache/datasketches-cpp#535). A TCK checkout can then serve directly as an implementation's test data root, and moving files between the TCK and an implementation is a plain copy. ## Changes - `git mv` of all 735 `.sk` files. File contents are unchanged. - `internal/snapshots/reconcile.go`: a `snapshotDirectory` helper now holds the layout in one place. - `cmd/tck` output test and snapshot: updated to the new path. - `docs/serialization-snapshots.md`: new paths, and a note on why the layout matches the implementations. ## Verification - `mise run check` - `mise run tck -- snapshots check go` against the moved files: file set and deterministic contents match. ## Follow-up Java's `tools/download_serialization_test_data.sh` needs a small change after this merges: the member pattern becomes `*/serialization_test_data/<lang>_generated_files/*.sk`, `--strip-components` goes from 4 to 3, and `TCK_REVISION` moves to the merge commit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
