tisonkun opened a new pull request, #291: URL: https://github.com/apache/datasketches-rust/pull/291
HLL List and Set serialization always produces compact images, but both writers retain a hard-coded `compact = true` and branches for an output format callers cannot select. Make that contract explicit in the flags, capacity calculation, and `HllSketch::serialize` documentation. Use the existing occupied-coupon iterator for List output, retaining its declared-count limit and coupon order. Set output uses its existing iterator directly. Serialized bytes and deserialization behavior are preserved. Validation: - `cargo x check`, `cargo x test` (746 tests), and `cargo x lint` passed. - Existing tests compare coupon-mode output byte-for-byte with 36 C++, Java, and Go reference images. - An external baseline/candidate probe matched serialized bytes and estimate bits for 175,887 states, including all three HLL types, `lg_k` 4–21, representation transitions, sparse updatable images, declared List count boundaries, and continued updates after deserialization. This is an internal readability refactor; no performance improvement is claimed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
