tisonkun opened a new pull request, #17: URL: https://github.com/apache/datasketches-tck/pull/17
An upstream revision change currently bypasses `--skip-unstable-only`, so the snapshot workflow can commit a new pin and random snapshot differences even when the compatibility corpus has no substantive change. With the flag, adopt a source only when a file is added or deleted, or stable contents change. Otherwise retain its complete snapshot directory and its existing config pin together, including when the generated output is byte-identical at a different revision. Default updates still adopt the requested revision and all generated differences. The policy applies independently to each language while preserving batch publication and rollback behavior. Reuse the existing blocking-change predicate and remove `UnstableOnly()`; no new fields or flags are needed. CLI output distinguishes retained pins from generated revisions, and workflow commit messages include skipped-source outcomes. Update the documentation and behavior matrix accordingly. Validation: - `mise run check` passed (formatting, lint, and all Go tests). - Regression tests cover changed revisions with identical or unstable-only output, default adoption, additions/deletions, stable changes, and a mixed batch retaining one source's pin. The new retention cases failed against the previous implementation. - Ran the updated CLI against the real Go upstream in a temporary copy of the pre-update TCK corpus: pin `757a485a1cb8df2873ea61da28d9b4053eee6852`, generated `fdcffae6c0c42be7576012a772ec287e242b1887`. All 42 differences were unstable; config and every snapshot remained unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
