Xuanwo commented on code in PR #300: URL: https://github.com/apache/datasketches-rust/pull/300#discussion_r4356460956
########## tests-integration/tests/countmin_test/sketch.rs: ########## Review Comment: I have reviewed the logic here, and found that: The reduction is exact, not approximate: fast_remainder and the power-of-two mask both return exactly what % returned, so bucket placement, estimates, and error bounds are bit-for-bit unchanged. `test_fast_remainder_matches_remainder` already cross-checks this against % over the full supported divisor range. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
