tisonkun commented on code in PR #300:
URL: https://github.com/apache/datasketches-rust/pull/300#discussion_r4357033830
##########
datasketches/src/countmin/sketch.rs:
##########
@@ -55,6 +55,8 @@ pub struct CountMinSketch<T: CountMinValue> {
total_weight: T,
counts: Vec<T>,
hash_seeds: Vec<u64>,
+ /// Multiplier for [`fast_remainder`], derived from `num_buckets`.
+ bucket_multiplier: u128,
Review Comment:
I personally find this field name strange, but I cannot find a better
alternative.
I can live with it anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
