On Tue, 2012-12-18 at 19:26 +0200, [email protected] wrote: > diff --git a/server/lib/deltacloud/drivers/cimi_features.rb > b/server/lib/deltacloud/drivers/cimi_features.rb > new file mode 100644 > index 0000000..adcdcbf > --- /dev/null > +++ b/server/lib/deltacloud/drivers/cimi_features.rb > @@ -0,0 +1,48 @@ > +# Licensed to the Apache Software Foundation (ASF) under one or more > +# contributor license agreements. See the NOTICE file distributed with > +# this work for additional information regarding copyright ownership. The > +# ASF licenses this file to you under the Apache License, Version 2.0 (the > +# "License"); you may not use this file except in compliance with the > +# License. You may obtain a copy of the License at > +# > +# http://www.apache.org/licenses/LICENSE-2.0 > +# > +# Unless required by applicable law or agreed to in writing, software > +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT > +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the > +# License for the specific language governing permissions and limitations > +# under the License. > + > +module CIMI > + module Features > + > + def self.included(k) > + current_features = features > + k.instance_eval do > + features(¤t_features) > + end > + end > + > + def self.features(&block) > + block_given? ? @features = block : @features || Proc.new{} > + end
This isn't so much a comment on your patch, but on our code in general: the whole feature handling is making me dizzy. We should have another look and make sure we separate the feature declaration DSL better from the code that actually declares features. That would hopefully let us avoid duplicating code between CIMI::Features and Deltacloud::Features. David
