On 19/12/12 00:41, David Lutterkort wrote: > Hi Marios, > > some comments: > > On Tue, 2012-12-18 at 19:26 +0200, [email protected] wrote: >> diff --git a/server/lib/cimi/collections/machines.rb >> b/server/lib/cimi/collections/machines.rb >> index b18fb1c..e5e1836 100644 >> --- a/server/lib/cimi/collections/machines.rb >> +++ b/server/lib/cimi/collections/machines.rb >> @@ -16,7 +16,10 @@ >> module CIMI::Collections >> class Machines < Base >> >> + include CIMI::Features > > Shouldn't this go into CIMI::Collections::Base ? We don't want to have > to repeat that for every entity that exposes capabilities. >
yes, good idea done. >> diff --git a/server/lib/cimi/collections/volume_templates.rb >> b/server/lib/cimi/collections/volume_templates.rb >> new file mode 100644 >> index 0000000..c73934e >> --- /dev/null >> +++ b/server/lib/cimi/collections/volume_templates.rb > > I'll just repeat my grumbly point that this should go into a different > patch, since it doesn't have anything to do with capabilities. > well - the only reason I had to touch volume_templates *_at_all_* here is that, since we didn't have this collection defined - the 'volume_templates_url' helper wasn't exposed. I needed this for the 'type_uri' of each resourceMetadata entry... (even though I may be wrong about the typeURI - addressed in the other "RMD Capabilities test plan" e-mail) >> diff --git a/server/lib/cimi/models/volume_template.rb >> b/server/lib/cimi/models/volume_template.rb >> index b2ac323..bb632c6 100644 >> --- a/server/lib/cimi/models/volume_template.rb >> +++ b/server/lib/cimi/models/volume_template.rb >> @@ -22,4 +22,7 @@ class CIMI::Model::VolumeTemplate < CIMI::Model::Base >> array :operations do >> scalar :rel, :href >> end >> + >> + def self.find(id, context) >> + end > > As Ronelle noticed, this will just make retrieving volume templates blow > up. as above - i didn't really want to tackle volume_templates here as well as resource meta - its a separate issue. For rev2 I'll just do the bare minimum so things don't explode - we can more fully implement volume templates (using the db layer - needs some thought) afterwards, marios > > David > >
