[ 
https://issues.apache.org/jira/browse/DTACLOUD-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566628#comment-13566628
 ] 

Marios Andreou commented on DTACLOUD-441:
-----------------------------------------

in general I don't object too much to this patch. I do have a concern about the 
"wait_until_running_or_stopped(res, instance_id)" business - but if there is no 
other way for these tests to run against fgcp then I guess we don't have a 
choice (my concern is simply the time taken to run these tests) - before you 
push these I'll ask Ronelle to also check out these patches as she runs these 
tests nightly... that will also give us a better picture of issues against 
other providers. 
                
> api tests don't clean up after themselves
> -----------------------------------------
>
>                 Key: DTACLOUD-441
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-441
>             Project: DeltaCloud
>          Issue Type: Test
>          Components: Server
>         Environment: Fgcp driver
>            Reporter: Dies Koper
>            Assignee: Dies Koper
>            Priority: Minor
>         Attachments: [PATCH] DTACLOUD441-442.eml
>
>
> When running DC api tests (rake tests:deltacloud in root tests folder), the 
> following is logged at the end (when using with Fgcp):
> CLEANING UP... resources for deletion: {:firewalls=>[], 
> :instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"], :keys=>[], :images=>[]}
> CLEANUP attempt finished... resources looks like: 
> {:instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"]}
> deltacloud/instances_test.rb:71: Unable to delete all created resources - 
> please check: {:instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"]} (Ex
> ception)
>         from deltacloud/instances_test.rb:244:in `call'
>         from deltacloud/instances_test.rb:244:in `to_proc'
>         from 
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/unit.rb:782:in
>  `reverse_each'
>         from 
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/unit.rb:782:in
>  `autorun'
> The reason it failed to delete them is because it only tried to stop them, 
> not destroy them. For Fgcp, stopping an instance doesn't destroy it.
> Suggesting to add code that calls the destroy_instance operation on instances 
> after the stop operation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to