[
https://issues.apache.org/jira/browse/DTACLOUD-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567626#comment-13567626
]
Ronelle Landy commented on DTACLOUD-441:
----------------------------------------
Found my original comments - putting them back for tracking
In principle, I'm not opposed to the spirit of these changes, I actually
support them (we do something similar in the cimi tests) but we will likely hit
a few compatibility issues with one or another provider. A few initial comments:
- Running rake testeltacloud against the first 'real' provider I tried,
Vsphere, failed out at line:
"res = get(INSTANCES+"/"+@@my_instance_id)" as @@my_instance_id returned nil
(coming from : @@my_instance_id = (res.xml/'instance')[0][:id])
Running the tests against Openstack got by this line. Openstack did die on
(test_0012_should allow to snapshot running instance if supported by provider)
but unlikely related to this change - still waiting for that functionality to
hit master.
- Examining the state transitions it seems like, in general, <start> PENDING
-> RUNNING/STOPPED <stop> STOPPING -> STOPPED. I'm not sure that all the
providers we verify against use the same terms - thought maybe one used
"STARTED" but I'm still looking for which one . There's always the occasional
PAUSED and NEW states.
- I hear the concern Marios raised about performance - although it's hard to
get a real estimate until we run the tests in the usual nightly kickoff - right
now I'm applying the patch and running provider by provider
- I'm not super crazy about the provider-specific comments in instances_test.rb
as in:
"233 #(this also prevents failures with fgcp where the ongoing creation
234 #operation blocks subsequent creation/deletion operations until
completed)"
fgcp is one of maybe 17 providers we could test
In place of driver specific comments, maybe we can switch on the driver and
only execute the "wait_until_running_or_stopped(res, created_instance_id)" if
the driver in the config.yaml has the switch to do so. This would minimize the
performance concerns and still allow fgcp a robust path through the tests.
> api tests don't clean up after themselves
> -----------------------------------------
>
> Key: DTACLOUD-441
> URL: https://issues.apache.org/jira/browse/DTACLOUD-441
> Project: DeltaCloud
> Issue Type: Test
> Components: Server
> Environment: Fgcp driver
> Reporter: Dies Koper
> Assignee: Ronelle Landy
> Priority: Minor
> Attachments: [PATCH] DTACLOUD441-442.eml
>
>
> When running DC api tests (rake tests:deltacloud in root tests folder), the
> following is logged at the end (when using with Fgcp):
> CLEANING UP... resources for deletion: {:firewalls=>[],
> :instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"], :keys=>[], :images=>[]}
> CLEANUP attempt finished... resources looks like:
> {:instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"]}
> deltacloud/instances_test.rb:71: Unable to delete all created resources -
> please check: {:instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"]} (Ex
> ception)
> from deltacloud/instances_test.rb:244:in `call'
> from deltacloud/instances_test.rb:244:in `to_proc'
> from
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/unit.rb:782:in
> `reverse_each'
> from
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/unit.rb:782:in
> `autorun'
> The reason it failed to delete them is because it only tried to stop them,
> not destroy them. For Fgcp, stopping an instance doesn't destroy it.
> Suggesting to add code that calls the destroy_instance operation on instances
> after the stop operation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
