On 03/07/2013 02:23 PM, jvlcek wrote:
> On 03/07/2013 12:49 PM, David Lutterkort wrote:
>> On Thu, 2013-03-07 at 09:14 -0500, jvlcek wrote:
>>> On 03/06/2013 08:31 PM, David Lutterkort wrote:
>>>> Am I the only one who runs into errors running 'rake test' ? I've got a
>>>> bunch of fixes that I'll send out in a minute, but I still get errors
>>>> from test:drivers:rhevm - seems like the fixtures need to be rerecorded.
>>>>
>>>> Can others run rake test successfully ?
>>>>
>>>> David
>>>>
>>>>
>>> I had just re-recorded the fixtures for test:drivers:rhevm a few days
>>> ago. Do you have the latest bits?
>> Yes. Part of the problem is that VCR matches on the full URL; the first
>> patch changes it so that it only matches on method, path and query
>> params (though I think RHEV-M doesn't use the latter)
>>
>> We also leak a good bit of information with our recordings. The second
>> (untested) patch tries to scrub user, password, and hostname from the
>> recordings.
>>
>> Finally, I also attach the test failures I get with these changes; it's
>> better than with current HEAD (e884d128). It looks like the failure is
>> genuinely because we need rerecording.
>>
>> BTW, this is with the latest rbovirt (rbovirt-0.0.18)
>>
>> David
>>
>
> The latest bits seem to run fine. See the attached.
>
> I believe the issue is the patch:
> 0001-RHEVM-tests-have-VCR-match-only-on-path-and-query-no.path
> the match_request_on is not needed.
>
> It should use:
> c.default_cassette_options = { :record => :none }
>
>
> I've discussed the leaking information issue with Michal and Marios.
>
> For all future recordings the approach is to use ~/.deltacloud/config to
> do the recordings.
> Then to set the user and pass to fakeuser and fakepassword in the
> recorded fixtures YAML
> files after doing the recording. Which is much easier to do than it sounds.
> This will match the returns from the credentials and driver methods in
> tests/test_helper.rb
>
> For existing recordings the credentials on the cloud providers are to be
> changed so they
> do not match those that had been used during the recording. This does
> leave some UUID
> information for the most part are ephemeral.
>
> Joe V
>I think the change proposed change in [PATCH 2/2] RHEVM tests: do not record username/password/hostname with VCR should align with the returns from credentials and driver methods in tests/test_helper.r that is h.user = "admin" u.password = "secret" to h.user = "fakeuser" h.password = "fakepassword" Because it is more possible that admin:secret could be used for live creds than fakeuser:fakepassword. Also could limiting the match_request_on perhaps result in erroneous matches? I've posted a "SITE:" change patch to try to document these tests and how to record them in:http://tracker.deltacloud.org/set/379 Joe V.
