On Thu, 2013-03-07 at 14:23 -0500, jvlcek wrote:
> The latest bits seem to run fine. See the attached.

What RUby version do you use ? Can you send me your Gemfile.lock ?

> I believe the issue is the patch:
> 0001-RHEVM-tests-have-VCR-match-only-on-path-and-query-no.path
> the match_request_on is not needed.

No, it is very much needed - without restricting the matching, I get
even more test failures.

It's also not logical that we'd want to match on hostname for RHEV-M. As
far as the tests are concerned, the host names do not matter.

> I've discussed the leaking information issue with Michal and Marios.
> 
> For all future recordings the approach is to use ~/.deltacloud/config to
> do the recordings.
> Then to set the user and pass to fakeuser and fakepassword in the
> recorded fixtures YAML
> files after doing the recording. Which is much easier to do than it sounds.

Have you tried out the second patch I sent ? It should do that without
any sed magic.

> This will match the returns from the credentials and driver methods in
> tests/test_helper.rb

With the changes to match_request_on I sent you, it doesn't matter at
all what credentials are used during playback - which is what we want.

It seems to be indeed the case that having a ~/.deltacloud/config during
playback causes the test failures. I want to get to a point where tests
pass even if that file exists.

> For existing recordings the credentials on the cloud providers are to be
> changed so they
> do not match those that had been used during the recording. This does
> leave some UUID
> information for the most part are ephemeral.

I don't care about leaking UUID, but we do have a good amount of real
user info and hostnames in the recordings right now.

David


Reply via email to