-1 for cdi unit (name already in use for the exact same purpose) +1 for renaming cdictrl to container-control
+1 for aligning both under modules (even though cdictrl has no deps on core, making it a module makes it easier to understand from a user's point of view). Personally, since it's an upgrade of the version # people just need to be aware of it when doing the upgrade locally in their projects (e.g. we can put some notes out there on what needs to be done to upgrade). On Mon, Feb 10, 2014 at 5:47 AM, Romain Manni-Bucau <[email protected]> wrote: > test-control could be renamed cdi-unit or something like it IMHO > Romain Manni-Bucau > Twitter: @rmannibucau > Blog: http://rmannibucau.wordpress.com/ > LinkedIn: http://fr.linkedin.com/in/rmannibucau > Github: https://github.com/rmannibucau > > > > 2014-02-10 11:28 GMT+01:00 Gerhard Petracek <[email protected]>: >> i wouldn't move test-control, since it's a module based on deltaspike-core. >> (cdictrl isn't based on deltaspike-core.) >> >> regards, >> gerhard >> >> >> >> 2014-02-10 11:15 GMT+01:00 Mark Struberg <[email protected]>: >> >>> Well, cdictrl is released already. Thus I would rather not change it's >>> name. >>> test-control is not yet released. So that would be easier to change. >>> >>> LieGrue, >>> strub >>> >>> >>> >>> >>> >>> On Sunday, 9 February 2014, 20:16, Karl Kildén <[email protected]> >>> wrote: >>> >>> Hello, >>> > >>> >I know it's been discussed before but now with a module called >>> test-control >>> >it just feel unnecessary to be inconsistent even though cdiCtrl is not a >>> >module it's not so pretty... >>> > >>> >Cheers / Karl >>> > >>> > >>> > >>>
