In a case like this, we can add a method releaseInstance to the bval module to match what's in the spec. It couldn't have @Override since it wouldn't match for bean validation 1.0.
Realistically if you're targeting an EE7/ bean val 1.1 this module makes no sense and you're actually being detrimental to how the runtime is meant to work. Personally, I've been using hibernate validator cdi module to solve this in an SE app.I'm not sure if apache bval is using a standalone CDI module or expecting the app servers to implement it. John On Fri, Aug 21, 2015 at 1:45 PM Gerhard Petracek <gerhard.petra...@gmail.com> wrote: > @thomas: > we could do that, however, we would need to check several topics (e.g.: the > overhead and possible side-effects with bv v1.1+). > > regards, > gerhard > > > > 2015-08-21 19:18 GMT+02:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > > > shouldnt a runtime validation be done as well? > > > > +1 to support/tolerate server upgrade without repackaging > > > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <http://rmannibucau.wordpress.com> | Github < > > https://github.com/rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber > > <http://www.tomitribe.com> > > > > 2015-08-21 10:17 GMT-07:00 Thomas Andraschko < > andraschko.tho...@gmail.com > > >: > > > > > IMO the module should work on both EE6 and EE7. > > > We often provide a WAR file and the customers decide where to deploy > it. > > > > > > 2015-08-21 19:00 GMT+02:00 Gerhard Petracek < > gerhard.petra...@gmail.com > > >: > > > > > > > @ee6 only: that's correct > > > > however, it looks like that user is using a manual setup with bv > v1.1. > > > > -> we need to add that information to the documentation (about ee6 > and > > bv > > > > v1.0) and/or we validate the bv-api with an extension. > > > > > > > > regards, > > > > gerhard > > > > > > > > > > > > > > > > 2015-08-21 17:35 GMT+02:00 Rafael Benevides <rbene...@redhat.com>: > > > > > > > > > Yeap. > > > > > > > > > > You right! > > > > > > > > > > In this case I think we should drop a note at > > > > > http://deltaspike.apache.org/documentation/bean-validation.html > > about > > > > it. > > > > > > > > > > > > > > > On Fri, Aug 21, 2015 at 11:16 AM, John D. Ament < > > johndam...@apache.org > > > > > > > > > wrote: > > > > > > > > > > > Rafael, > > > > > > > > > > > > The bean validation module should not be used in EE 7 app > servers, > > it > > > > was > > > > > > meant to plug a hole in EE 6 containers to continue to leverage > > > > injection > > > > > > into EE 6 constraint validators (a need I had at the time, which > is > > > now > > > > > > replaced by using an EE 7 container). > > > > > > > > > > > > John > > > > > > > > > > > > On Fri, Aug 21, 2015 at 11:09 AM Rafael Benevides < > > > rbene...@redhat.com > > > > > > > > > > > wrote: > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > Yesterday Gerhard asked me to take a look at the following > issue: > > > > > > > https://github.com/jpangamarca/bean-validation-shutdown-issue > > > > > > > > > > > > > > After some investigation I found that > ConstraintValidatorFactory > > > > > > included a > > > > > > > new method in Java EE 7 (#releaseInstance > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://docs.oracle.com/javaee/7/api/javax/validation/ConstraintValidatorFactory.html#releaseInstance-javax.validation.ConstraintValidator- > > > > > > > > > > > > > > > ) > > > > > > > > > > > > > > - ConstraintValidatorFactory (Java EE 6): > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://docs.oracle.com/javaee/6/api/javax/validation/ConstraintValidatorFactory.html > > > > > > > - ConstraintValidatorFactory (Java EE 7): > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://docs.oracle.com/javaee/7/api/javax/validation/ConstraintValidatorFactory.html > > > > > > > > > > > > > > This email is to discuss the expected approach for this issue: > > > > > > > > > > > > > > 1) Create a new artifact for Java EE > > > > > > > 7: deltaspike-bean-validation-module-impl-ee7 > > > > > > > > > > > > > > 2) Upgrade the current supported version to BV 1.1 (Java EE 7) > > > > > > > > > > > > > > 3) Others. > > > > > > > > > > > > > > So What are your thoughts about this issue and what's the > > approach > > > > that > > > > > > > DeltaSpike is using to leave with changes from EE6 to EE7? > > > > > > > > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > *Rafael Benevides | Senior Software Engineer* > > > > > > > JBoss Developer Materials lead > > > > > > > M: +1-919-592-6255 > > > > > > > > > > > > > > > > > > > > > > > > > > > > Better technology. Faster innovation. Powered by community > > > > > collaboration. > > > > > > > See how it works at www.redhat.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > *Rafael Benevides | Senior Software Engineer* > > > > > JBoss Developer Materials lead > > > > > M: +1-919-592-6255 > > > > > > > > > > > > > > > > > > > > Better technology. Faster innovation. Powered by community > > > collaboration. > > > > > See how it works at www.redhat.com > > > > > > > > > > > > > > >
