klesh commented on PR #112:
URL: 
https://github.com/apache/incubator-devlake-helm-chart/pull/112#issuecomment-1512357700

   > For external MySQL we do not need MySQL root password, we only need the 
user/pass for the lake database. But for MySQL server with our helm chart, 
follow the description by https://hub.docker.com/_/mysql, the 
MYSQL_ROOT_PASSWORD is mandatory for starting a MySQL instance, so that's why 
we initially use the parameter `rootPassword ` for user input
   
   Nice, just the way I thought it should be.
   The only problem left is how we can convey the idea to our users clearly.
   From the current comment, users can not tell what is it for. We should add 
more context to explain why he needs to fill in the `rootPassword` in the first 
place, or, he might still fill in an existing `rootPassword` from some database 
server by mistake, we don't want that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to